irmd: Revise IRMd internals

This is a full revision of the IRMd internal implementation.

The registry is now a proper subcomponent managing its own internal
lock (a single mutex). Some tests are added for the registry and its
data structures. Some macros for tests are added in <ouroboros/test.h>.

Flow allocation is now more symmetric between the client side (alloc)
and server size (accept). Each will create a flow in pending state
(ALLOC_PENDING/ACCEPT_PENDING) that is potentially fulfilled by an
IPCP using respond_alloc and respond_accept primitives. Deallocation
is split in flow_dealloc (application side) and ipcp_flow_dealloc
(IPCP side) to get the flow in DEALLOC_PENDING and DEALLOCATED state.

Cleanup of failed flow allocation is now properly handled instead of
relying on the sanitizer thread. The new sanitizer only needs to
monitor crashed processes.

On shutdown, the IRMd will now detect hanging processes and SIGKILL
them and clean up their fuse mountpoints if needed.

A lot of other things have been cleaned up and shuffled around a bit.

Signed-off-by: Dimitri Staessens <[email protected]>
Signed-off-by: Sander Vrijders <[email protected]>

1 files changed, 11 insertions, 9 deletions

diff --git a/src/lib/shm_rbuff_pthr.c b/src/lib/shm_rbuff_pthr.c
index 1ee346e8..b543fb07 100644
--- a/src/lib/shm_rbuff_pthr.c
+++ b/src/lib/shm_rbuff_pthr.c
@@ -24,7 +24,7 @@ void shm_rbuff_destroy(struct shm_rbuff * rb)
 {
         char fn[FN_MAX_CHARS];
 
-        assert(rb);
+        assert(rb != NULL);
 
 #ifdef CONFIG_OUROBOROS_DEBUG
         pthread_mutex_lock(rb->lock);
@@ -48,7 +48,7 @@ int shm_rbuff_write(struct shm_rbuff * rb,
 {
         int ret = 0;
 
-        assert(rb);
+        assert(rb != NULL);
         assert(idx < SHM_BUFFER_SIZE);
 
 #ifndef HAVE_ROBUST_MUTEX
@@ -91,7 +91,7 @@ int shm_rbuff_write_b(struct shm_rbuff *      rb,
 {
         int ret = 0;
 
-        assert(rb);
+        assert(rb != NULL);
         assert(idx < SHM_BUFFER_SIZE);
 
 #ifndef HAVE_ROBUST_MUTEX
@@ -138,6 +138,8 @@ int shm_rbuff_write_b(struct shm_rbuff *      rb,
 
 static int check_rb_acl(struct shm_rbuff * rb)
 {
+        assert(rb != NULL);
+
         if (*rb->acl & ACL_FLOWDOWN)
                 return -EFLOWDOWN;
 
@@ -151,7 +153,7 @@ ssize_t shm_rbuff_read(struct shm_rbuff * rb)
 {
         ssize_t ret = 0;
 
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);
@@ -180,7 +182,7 @@ ssize_t shm_rbuff_read_b(struct shm_rbuff *      rb,
 {
         ssize_t idx = -1;
 
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);
@@ -224,7 +226,7 @@ ssize_t shm_rbuff_read_b(struct shm_rbuff *      rb,
 void shm_rbuff_set_acl(struct shm_rbuff * rb,
                        uint32_t           flags)
 {
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);
@@ -244,7 +246,7 @@ uint32_t shm_rbuff_get_acl(struct shm_rbuff * rb)
 {
         uint32_t flags;
 
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);
@@ -261,7 +263,7 @@ uint32_t shm_rbuff_get_acl(struct shm_rbuff * rb)
 
 void shm_rbuff_fini(struct shm_rbuff * rb)
 {
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);
@@ -285,7 +287,7 @@ size_t shm_rbuff_queued(struct shm_rbuff * rb)
 {
         size_t ret;
 
-        assert(rb);
+        assert(rb != NULL);
 
 #ifndef HAVE_ROBUST_MUTEX
         pthread_mutex_lock(rb->lock);