irmd: Revise IRMd internals

This is a full revision of the IRMd internal implementation.

The registry is now a proper subcomponent managing its own internal
lock (a single mutex). Some tests are added for the registry and its
data structures. Some macros for tests are added in <ouroboros/test.h>.

Flow allocation is now more symmetric between the client side (alloc)
and server size (accept). Each will create a flow in pending state
(ALLOC_PENDING/ACCEPT_PENDING) that is potentially fulfilled by an
IPCP using respond_alloc and respond_accept primitives. Deallocation
is split in flow_dealloc (application side) and ipcp_flow_dealloc
(IPCP side) to get the flow in DEALLOC_PENDING and DEALLOCATED state.

Cleanup of failed flow allocation is now properly handled instead of
relying on the sanitizer thread. The new sanitizer only needs to
monitor crashed processes.

On shutdown, the IRMd will now detect hanging processes and SIGKILL
them and clean up their fuse mountpoints if needed.

A lot of other things have been cleaned up and shuffled around a bit.

Signed-off-by: Dimitri Staessens <[email protected]>
Signed-off-by: Sander Vrijders <[email protected]>

1 files changed, 12 insertions, 31 deletions

diff --git a/src/irmd/reg/proc.h b/src/irmd/reg/proc.h
index 03a6cf96..99f74fef 100644
--- a/src/irmd/reg/proc.h
+++ b/src/irmd/reg/proc.h
@@ -23,48 +23,26 @@
 #ifndef OUROBOROS_IRMD_REG_PROC_H
 #define OUROBOROS_IRMD_REG_PROC_H
 
+#include <ouroboros/list.h>
+#include <ouroboros/proc.h>
 #include <ouroboros/shm_flow_set.h>
 
-#include "utils.h"
-
-#include <unistd.h>
-#include <ouroboros/pthread.h>
-
-enum proc_state {
-        PROC_NULL = 0,
-        PROC_INIT,
-        PROC_SLEEP,
-        PROC_WAKE,
-        PROC_DESTROY
-};
-
 struct reg_proc {
         struct list_head      next;
-        pid_t                 pid;
-        char *                prog;  /* program instantiated */
-        struct list_head      names; /* names for which process accepts flows */
-        struct shm_flow_set * set;
 
-        struct reg_name *     name;  /* name for which a flow arrived */
+        struct proc_info      info;
 
-        /* The process will block on this */
-        enum proc_state       state;
-        pthread_cond_t        cond;
-        pthread_mutex_t       lock;
+        struct list_head      names;   /* names for which process accepts flows */
+        size_t                n_names; /* number of names                       */
+
+        struct shm_flow_set * set;
 };
 
-struct reg_proc * reg_proc_create(pid_t        proc,
-                                  const char * prog);
+struct reg_proc * reg_proc_create(const struct proc_info * info);
 
 void              reg_proc_destroy(struct reg_proc * proc);
 
-int               reg_proc_sleep(struct reg_proc * proc,
-                                 struct timespec * timeo);
-
-void              reg_proc_wake(struct reg_proc * proc,
-                                struct reg_name * name);
-
-void              reg_proc_cancel(struct reg_proc * proc);
+void              reg_proc_clear(struct reg_proc * proc);
 
 int               reg_proc_add_name(struct reg_proc * proc,
                                     const char *      name);
@@ -72,4 +50,7 @@ int               reg_proc_add_name(struct reg_proc * proc,
 void              reg_proc_del_name(struct reg_proc * proc,
                                     const char *      name);
 
+bool              reg_proc_has_name(const struct reg_proc * proc,
+                                    const char *            name);
+
 #endif /* OUROBOROS_IRMD_REG_PROC_H */