ipcpd, lib: Report IPCP creation failure

The IPCP will now respond with an ipcp_create_r message when it fails,
informing the IRMd.

Also adds some const qualifiers in the public headers and fixes
some formatting in dev.c.

1 files changed, 6 insertions, 2 deletions

diff --git a/src/irmd/main.c b/src/irmd/main.c
index c029b4cf..74cb8359 100644
--- a/src/irmd/main.c
+++ b/src/irmd/main.c
@@ -303,10 +303,14 @@ static pid_t create_ipcp(char *         name,
         return api->pid;
 }
 
-static int create_ipcp_r(pid_t api)
+static int create_ipcp_r(pid_t api,
+                         int   result)
 {
         struct list_head * pos = NULL;
 
+        if (result != 0)
+                return result;
+
         pthread_rwlock_rdlock(&irmd->state_lock);
         pthread_rwlock_rdlock(&irmd->reg_lock);
 
@@ -1821,7 +1825,7 @@ void * mainloop(void * o)
                         break;
                 case IRM_MSG_CODE__IPCP_CREATE_R:
                         ret_msg.has_result = true;
-                        ret_msg.result = create_ipcp_r(msg->api);
+                        ret_msg.result = create_ipcp_r(msg->api, msg->result);
                         break;
                 case IRM_MSG_CODE__IRM_DESTROY_IPCP:
                         ret_msg.has_result = true;